Skip to content

Conversation

@JinZhou5042
Copy link
Member

@JinZhou5042 JinZhou5042 commented Nov 4, 2025

Proposed Changes

This PR includes the following features:

  • temp files related functions and logics are brought to a new file vine_temp.c, which controls file replication, redundancy cleanup, and disk load shifting.
  • temp_files_to_replicate is turned into a priority queue, files with least replicas are considerred first to replicate.
  • vine_prune will not trigger the removal of a record in temp_files_to_replicate, which makes the data pruning faster, the replication will fail silently if no available replicas.

Merge Checklist

The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update: Update the manual to reflect user-visible changes.
  • Type Labels: Select a github label for the type: bugfix, enhancement, etc.
  • Product Labels: Select a github label for the product: TaskVine, Makeflow, etc.
  • PR RTM: Mark your PR as ready to merge.

@JinZhou5042 JinZhou5042 marked this pull request as draft November 4, 2025 22:33
@JinZhou5042 JinZhou5042 marked this pull request as ready for review November 5, 2025 05:09
@JinZhou5042 JinZhou5042 self-assigned this Nov 5, 2025
@JinZhou5042 JinZhou5042 requested review from btovar and dthain November 5, 2025 20:16
Copy link
Member

@btovar btovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge?

@btovar
Copy link
Member

btovar commented Nov 5, 2025

I see you included the cleanup of redundant replicas. We should find a way so that the redundant tasks are not created.

@JinZhou5042
Copy link
Member Author

Could you elaborate a bit on what redundant tasks refer to?

@btovar
Copy link
Member

btovar commented Nov 5, 2025

Sorry, I misunderstood the source! Once you fix the conflicts I can merge this one.

@JinZhou5042 JinZhou5042 requested a review from btovar November 6, 2025 20:50
@dthain
Copy link
Member

dthain commented Nov 6, 2025

I think it makes sense to factor out distinct bits of code out of the manager like this.

It seems to me that this module is on top of vine_file_replica_table and so I'm trying to think of a more descriptive name than vine_temp.

But I don't have a better idea, so I think we should go with this!

@JinZhou5042
Copy link
Member Author

I think it makes sense to factor out distinct bits of code out of the manager like this.

It seems to me that this module is on top of vine_file_replica_table and so I'm trying to think of a more descriptive name than vine_temp.

But I don't have a better idea, so I think we should go with this!

Sounds great! Just pushed an empty commit to trigger the rebuild as it somehow failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants