-
Notifications
You must be signed in to change notification settings - Fork 124
vine: vine_temp.c #4269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
vine: vine_temp.c #4269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready to merge?
|
I see you included the cleanup of redundant replicas. We should find a way so that the redundant tasks are not created. |
|
Could you elaborate a bit on what redundant tasks refer to? |
|
Sorry, I misunderstood the source! Once you fix the conflicts I can merge this one. |
|
I think it makes sense to factor out distinct bits of code out of the manager like this. It seems to me that this module is on top of But I don't have a better idea, so I think we should go with this! |
Sounds great! Just pushed an empty commit to trigger the rebuild as it somehow failed. |
Proposed Changes
This PR includes the following features:
vine_temp.c, which controls file replication, redundancy cleanup, and disk load shifting.temp_files_to_replicateis turned into a priority queue, files with least replicas are considerred first to replicate.vine_prunewill not trigger the removal of a record intemp_files_to_replicate, which makes the data pruning faster, the replication will fail silently if no available replicas.Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.